List all keywords in TypeHelper.EscapeIdentifier #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#147
While attempting to convert a Java file, JavaToCSharp crashed while parsing the following method parameter
structis a keyword in C#, but not in Java. As such,JavaToCSharp.Declarations.MethodDeclarationVisitor.VisitInternalwas crashing hereon the basis that the value passed to the
identifierparameter was invalid.SyntaxFactory.ParseTokenwill produce a token of typeSyntaxKind.StructKeywordin response to parsingstructrather than a simple identifier token. Earlier inVisitInternalthe methodTypeHelper.EscapeIdentifieris called, which prepends@to several types of keywords. Not all keywords are listed here however, so I have updated the list to specify all standard keywords as defined here. There are additional contextual keywords in C# but these should not apply for the purposes of escaping an identifier.